2. Depends, all of the professions are good, the typical gathering ones are pretty good if you don't have any competition, alchemy is pretty good overall( Really nice trinket for healing), enchating aswell if you have the mats for it, and the patience to get all the recepies, leatherworking is always good for raiding cause drums + really nice healing chest for you when you reach swp
1. Yea resto sham is a good pick, only overpopulated raid classes imo are melees, prot pala, mages
2. Skinning is decent, herb pretty good but overbotted in Outland, mining is solid too but needs fast flyer to be worthwhile. Wouldn't suggest enchanting for making money, it's extremely flooded, just type "LF Ench mongoose" etc on global and you'll get insta-flooded with 10+ invites/whispers