Details! sunder armor count

Hi there, I prefer using Details over Skada/Recount but one thing is not working is Sunder Armor count

The script by default is:

Code:

---

                local combat, container, instance = ...
                local total, top, amount = 0, 0, 0

                local sunderName = GetSpellInfo(11597)
                local actors = combat:GetActorList(DETAILS_ATTRIBUTE_MISC)
                for i, actor in ipairs(actors) do
                        if actor:IsPlayer() and actor.spell_cast then
                                for spellName, count in pairs(actor.spell_cast) do
                                        if spellName == sunderName then
                                                container:AddValue(actor, count)
                                        end
                                end
                        end
                end

                total, top = container:GetTotalAndHighestValue()
                amount = container:GetNumActors()

                return total, top, amount

---

Any pro programmer know why this is not working? :D

Ty in advance

Quote:

---

Originally Posted by Smoorfz

Hi there, I prefer using Details over Skada/Recount but one thing is not working is Sunder Armor count
angry gran
The script by default is:

Code:

---

                local combat, container, instance = ...
                local total, top, amount = 0, 0, 0

                local sunderName = GetSpellInfo(11597)
                local actors = combat:GetActorList(DETAILS_ATTRIBUTE_MISC)
                for i, actor in ipairs(actors) do
                        if actor:IsPlayer() and actor.spell_cast then
                                for spellName, count in pairs(actor.spell_cast) do
                                        if spellName == sunderName then
                                                container:AddValue(actor, count)
                                        end
                                end
                        end
                end

                total, top = container:GetTotalAndHighestValue()
                amount = container:GetNumActors()

                return total, top, amount

---

Any pro programmer know why this is not working? :D

Ty in advance

---

It's a difficult problem to me. Normally, I will start by checking my information. For example, here, I will make sure that the spell ID or name used in the script (11597 and GetSpellInfo(11597)) matches the actual spell ID or name for Sunder Armor in the game. If the ID or name has changed for the spell, it may result in the count not being tracked correctly. It's a situation. Hope that it can help you.

Quote:

---

Originally Posted by donnaallenn

It's a difficult problem to me. Normally, I will start by checking my information. For example, here, I will make sure that the spell ID or name used in the script (11597 and GetSpellInfo(11597)) matches the actual spell ID or name for Sunder Armor in the game. If the ID or name has changed for the spell, it may result in the count not being tracked correctly. It's a situation. Hope that it can help you.

---

Thx for your reply. You were right, the ID for Sunder Armor used in fury/arms spec is the 7386 (https://www.wowhead.com/wotlk/spell=7386/sunder-armor)

I also did found something that might be wrong:
I found that in file spells.lua (https://github.com/Bunny67/Details-W...ons/spells.lua) Sunder Armor was not specified with this spell ID, line 719. I've added it but no luck, script isnt logging anything u.u
So it might be something else , maybe that actor.spell_cast is not working... Cause I think this script is developed posterior to 3.3.5 and internal library that uses is not compatible? Idk, too much deep stuff u.u
I think I'll just try to find some extra addon or weakaura to track this (or use Skada, but didnt wanna to have both since its function is the same)