Skada Revisited

AddOn Update.

Changelog 2020-11-16

• Added some useful damage and adds overkill. This concept was used by Invisus guild (I was told), so I implemented it and it contains: Lady Deathwhisper Adds damage, Professor Putricide Oozes damage, Halion and Inferno damage, The Lich King Useful targets damage, Valkyrs overkilling and Princes overkilling for BPC

AddOn Updated.

Changelog 2020-11-23

• Damage module changed and now stores the overkill, used by the new module called Useful damage that removes overkill from consideration.
• Icecrown Gunship Battle, Blood Prince Council and Valithrida Dreamwalker segments will use the boss names instead of the mobs or sub-bosses.
• Failbot was fixed. Clicking on the player shows his/her fails. Clicking on the fail shows the player that failed.
• Added extra font "Hooger"
• Moved from AceTimer-3.0 to C_Timer
• Fixed Absorbs module causing lua error : "Invalid order function for sorting"
• Fixed GetPlayerInfoByGUID issue (lua tail call).

Did u updated it in repo? I just tried it a minute ago, and still "Invalid order function for sorting"
https://imgur.com/a/AurGmA7

Quote:

---

Originally Posted by frozzypix

Did u updated it in repo? I just tried it a minute ago, and still "Invalid order function for sorting"
https://imgur.com/a/AurGmA7

---

Can you please download this file, replace the old one then do a simple /reload to test? (drop it insides modules folder please)

Hey, thanks for your addon, it's great.

Could you add more data on hover on this page ? Like min/max/average?

https://i.imgur.com/picG8zM.png

Cheers.

Quote:

---

Originally Posted by halesk70

Hey, thanks for your addon, it's great.

---

You're welcome! Glad you like it.

Quote:

---

Originally Posted by halesk70

Could you add more data on hover on this page ? Like min/max/average?
https://i.imgur.com/picG8zM.png

---

The screenshot doesn't say anything about the mode.

It's the damage done by spell mode

https://i.imgur.com/ClqIF3p.png

Can you please tell me how did you get to that last page? Because I went through Damage, Damage done by spell, Enemy damage done, I didn't reach it.

EDIT:
If it is on Damage > Player > Spell, then there is already a tooltip with those details.

You are right, I updated the addon and it's right here. Thanks.

Quote:

---

Originally Posted by halesk70

You are right, I updated the addon and it's right here. Thanks.

---

You're welcome. You might want to update it again because I just pushed some changes to the repo, mainly fixing:

• "Invalud sort function" error seen on the Absorbs module.
• Formatted DPS for sollow Skada formatted number (for data feed and tooltips).
• GetPlayerInfoByGUID fix attempt (causing lua error - tail call)
• Removed some NPC that were causing trash before gunship battle being considered as "boss encounter", thus keeping the set if the players chooses to keep only bosses.

Hi, can u advice getting these 2 Lua errors:
https://imgur.com/a/YV2DLCu
https://imgur.com/a/SV4kTSN

Thanks

Quote:

---

Originally Posted by Widlajzik

Hi, can u advice getting these 2 Lua errors:
https://imgur.com/a/YV2DLCu
https://imgur.com/a/SV4kTSN
Thanks

---

Those errors were fixed, try to update the addon please and if you see them again let me know.

Bro where do i get the fileeeeeeeeeeee

Quote:

---

Originally Posted by beaunana

Bro where do i get the fileeeeeeeeeeee

---

First post, click Download :)

AddOn Update. You can check all commits and changes here.