Well for that which can i see, twilight will give you 763 sp from the start for 15 secs.
To get closely the same amount of sp from Foreign Object you will have to wait 12 secs from the proc. And on the next 4 ticks of the trinket will u have more sp bonus than the twilight scale.
Which means that only on the last 6 secs of the Foreign Object you will have more sp than the twilight scale.
So i think twilight is better, cuz you get big sp bonus at once for 15 secs, dont have to wait like 10 secs to feel it like with the foreign object.
DFO: 105 SP for the first 2 seconds to a maximum of 1050 SP on the final 2 seconds, simplified to:
(105+1050)/2 SP * 20s duration /45s internal cooldown = 256.6667 SP average
where the (105/1050)/2 part is DFO's average SP within its own duration (hence the second part is needed to account for internal cooldown).
Still, even without accounting for the proc types we can see that CTS is marginally better in most cases:
+8 Haste
-2 average SP
When we take proc type into account, this is where CTS becomes quite clearly superior, which is basically what stoyooo has explained above.
Procs typically take a few seconds to, well, proc, which gives CTS an advantage because its upfront proc bonus works better with stuff like prepotting (using a potion just before a pull), and cooldowns such as a Fire Mage's Combustion or an Engineer's Hyperspeed Accelerators. Meanwhile, by this point these cooldowns are used, DFO more likely than not would be at 3-4 stacks unless you go out of your way to time your cooldown use with it, and screwing the rest of your procs in the process.
tl;dr DFO gives very slightly more 'average SP' mathematically, but CTS's proc is much more effective in practical terms and is thus easily the better of the two imho.
I'd like to dig out this old thread because from the 23rd of March server update there's something touched in the CTS trinket.
"Maybe" something was wrong with it's proc rate, but nobody has the calculations to show how.
On the other hand, this is endgame trinket - if it's slightly over the top here maybe it is not so good, but it is far far more worse problem if after "fixing" it they have actually made it practically worse than other lower ilvl trinkets! https://www.warmane.com/bugtracker/report/64158
Below are top 20 trinkets for shadow priest for example, endlessly tested back in the days on retail, and imo dev's here must aim and confirm this after saying it's "fixed" so it doesn't turn out in the end that CTS here performs like #10 or lower trinket.
Trinket:
#01 Dislodged Foreign Object(277)
#02 Charred Twilight Scale(284)
#03 Phylactery of the Nameless Lich(277)
#04 Dislodged Foreign Object(264)
#05 Charred Twilight Scale(271)
#06 Phylactery of the Nameless Lich(264)
#07 Muradin's Spyglass(264)
#08 Reign of the Unliving(258) / Reign of the Dead(258)
#09 Muradin's Spyglass(251)
#10 Reign of the Unliving(245) / Reign of the Dead(245)
#11 Flare of the Heavens
#12 Glowing Twilight Scale(284)
#13 Althor's Abacus(277)
#14 Illustration of the Dragon Soul
#15 Scale of Fates
#16 Abyssal Rune
#17 Glowing Twilight Scale(271)
#18 Eye of the Broodmother
#19 Nevermelting Ice Crystal
#20 Althor's Abacus(264)