-
Member
Looks perfect now, but whatever you did seemed to have broken the caching thing or w/e you did earlier. Now you have to mouseover/click targets in bgs for the icons to appear again.
-
Member
Ok, next patch/fix round xD
i just updated the Core.lua with some fixes:
i added a BG Class Scanner that triggers when you enter a match. instead of constantly scanning in the background (which would tank FPS and cause micro-lags), i designed it to scan the scoreboard just once after a 30s buffer. since the teams don't really change once the BG starts, this one-time scan should grab all the class info we need while being extremely light on performance. in theory, this should show class icons on all enemy nameplates automatically without needing a mouseover first. i haven't had the chance to fully test this in a real match yet, so let me know if it works =)
Also fixed the bug where the Color Picker and pet detection would stop working after changing zones (database scope issue).
IMPORTANT: Sadly, you need to reset your settings for this. there was some weird bug in the local saved variables that caused nil errors with the new structure. i can't really explain why, but rebuilding the saves from scratch fixed the color picker here for me.
Plz:
go to WTF > Account > [YourAccountName] > SavedVariables.
delete TidyPlates.lua (+ .bak) and TidyPlates_ThreatPlates.lua (+ .bak).
delete your Cache folder too, just to be sure.
Log in and pick Threat Plates when the popup asks what to use, open /tidyplates and set pet color, and it should be there...
let me know if the BG icons pop up or if there still problems with the color picker for the pat... or (i don't hope so) anything else ^-^
<-- working here again for me
-
Member
Some feedback after testing a little:
- Pet color is still red
- the scanning part after 30 seconds doesn't really work, because the BG is rarely filled after 30 seconds. And players keep leaving/joining very often these days. You usually end up with like a half or more of them missing. I don't know if it's possible to scan once after 90 seconds or something, and then every time someones joins (if it's not too resource intensive).
- Chat bubbles no longer appears when you have friendly class icons (not a very big deal)
- I tried to change the timer to 90 myself, and it didn't seem to make any difference. In a 15 men bg, I usually only get like 5 icons.
- There also seems to be a flickering of the enemy healthbars. As if it's turning on and off extremely quickly. Sometimes it barely happens, but then it can suddenly happen several times a second.
-
Member
thanks for the detailed feedback, baartleby2!
i’ve just pushed a radical update to the repository. i’ve "hardened" the code to ensure it works across different server cores (warmane/trinity vs. azerothcore).
here is what changed:
bg scanner hardened: i’ve replaced the static timer with an event-driven system (update_battlefield_score). it now scans whenever the leaderboard updates (players joining/leaving) but uses a dedicated background frame with a safety throttle to keep your fps high. i also added a forced requestbattlefieldscoredata() to ensure the server actually sends the data to your client.
pet color fix: on my end (azerothcore), the colors worked fine, but i suspect warmane handles pet names differently (likely adding realm suffixes like "pet-servername"). i’ve added a helper function to strip these suffixes before the color-check. this should make the pet detection "server-agnostic."
flickering & chat bubbles: the flickering was likely caused by redundant update loops. i've cleaned up the core logic to prevent these "fights" between functions. also, the class icons now sit on a lower frame level and have mouse interaction disabled, which should bring your chat bubbles back.
important: because i’ve refactored the code quite radically to achieve this compatibility, please clear your cache and delete the addon’s savedvariables (wtf/account/.../savedvariables/tidyplates_threatplates.lua) before testing the new build.
it's rlly strange and atm it fu*** my brain xD i have three colleagues test this on azerothcore-based servers, and it’s working perfectly there. if the pet colors and bg icons still fail on warmane after this "hardened" update, i’m running out of "blind" ideas. in that case, i might have to use a sniffer on warmane to analyze and see how they handle data transmission differently.
i’m staying on top of this! please let me know if this build finally clears things up for you.
-
Member
The pet color works, but only on your own pet. Friendly/enemy pets still has default color.
I'm gonna test the other changes, and see how it works.
Edit:
- Class icons are perfect now. Haven't seen any flickering yet, will report if I do.
- I have class (enemy healthbar) colors enabled, and it weirdly turned one warrior's health bar blue for a few seconds just now.
- Pet color still doesn't work. Seems to only work on your own pets.
2nd Edit:
- Happened again. A war's healthbar color changed to blue this time.
- Noticed some flickering again, it's much rarer now though.
-
Member
nice! glad to hear the class icons are perfect now. that means the new event-system is doing its job. we're definitely getting closer to the finish line! xD
regarding the other points:
the blue warrior & flickering: that’s a strange one. since we disabled the threat-engine in bgs, the addon falls back to class/reaction colors. if it’s turning blue and still flickering, i might have been too aggressive with the new logic or it's a rendering conflict caused by my recent changes. i’m going to investigate this immediately—it could be a rendering bug where the frames "fight" for priority. i'll see if i can lock the colors more reliably.
pet colors: i finally found the missing link for the other pets! the problem was that while the search was fixed, the internal pet-list was still being filled with the full 'name-realm' strings from the server, so enemy/group pets never matched the search. i’ve now refactored the utility to globally filter and 'sanitize' these names at the source. they now use the same naming scheme as your own pet, so they should finally be recognized and colored correctly.
no need to delete savedvars this time, just update and you should be good to go. let's hope this covers all pets on warmane now ^-^
-
Member
- Chat bubbles still doesn't appear
- Pet colors are still red
- I noticed some more intensive flicking last game
-
Member
hey, thanks again for your help, it’s awesome that you're taking the time to test this so thoroughly xD
i've reached a point where i’m basically "fishing in the dark" because i can't replicate warmane’s cross-realm environment on my local setup. to really nail these bugs without wasting your time with 20 more "maybe" fixes, i’ve prepared a special debug build for you, cause tbh, if i were to start on warmane myself now, it would take way too long to reach the level range for meaningful bg data, and i simply don't have the time for that right now. so, your testing is pretty much the only way for me to get the data i need, preferably at different times, if possible.
debug build: https://github.com/hypopheria2k/Tidy...ug-warmane.zip
or https://github.com/hypopheria2k/Tidy....3.5a/releases
if you're up for it and have some time during your next few bg runs, it would be a huge help if you could log some data for me. no pressure at all, just whenever you feel like playing a few rounds:
the pet check: the chat will show yellow [PetCheck] lines. if you see a red pet, i’d love to know what the chat says for that specific name (is it in the list? is the realm name causing trouble?).
the guid check: the [GuidClass] lines will tell us if the game actually provides the class data via guid or if it’s returning "not found". this is likely the key to the flickering.
command: you can type /tpdebug anytime in a bg to print the current internal pet-list to your chat.
if you could grab some screenshots or copy the chat logs from a few different games/times, that would be amazing. the more data we have from different situations, the faster i can ship a clean, stable version for everyone.
really appreciate your patience and help with this, we're almost there!
-
Member
-
Member
damn, that helped a lot, thnx 4 that! =)
Some small points i noticed from your screenshots:
1. The pet colors:
Looking at your logs, the line isEnemyPetOption: false shows that the setting to color enemy pets is actually disabled in your options.
Could you check your settings please? Simply go to Threat Plates options -> Coloring and enable 'Apply to Enemy Pets'. Without this checkmark, the addon is not allowed to change the bar color. If you have the time, please try again with the debug mode to see if it works with the option enabled!
2. The flickering / blue warrior:
The logs show it clearly: [GuidClass] not found. It turns out the old WoW API is too slow to provide class data via GUID in BGs. This delay/missing data caused the flickering.
I'm going to rewrite the logic to rely 100% on my BG-scanner's data. No more guessing, no more slow API calls. Once the scanner sees them, the color is locked in.
Note on Open World PvP:
The downside is that this specific fix only works in BGs. In the Open World, the scanner is "blind". The only way to get the data there is a quick mouseover or target click on the enemy player so the addon can grab the class and cache it. For now, I'll focus on getting the BG logic rock-solid first.
One other setting to try:
Please enable the "Friendly caching" option under Class Icons. This enables a larger cache and helps the addon remember everyone's class throughout the entire match.
If you can give me feedback on these points (screens or just copy&paste the debug lines), I can finalize the solution. We are getting really close ^-^ thx 4 u'r help, rlly appricate it =)
-
Member
Except when I was already in a duel with a player with a enemy pet, and then did a /reload
https://imgur.com/a/JHOSpEq
If I relog, it's green/red again.
Edit: Seems to only work vs that character / that character's pet. I tried creating another character with a different pet, and I couldn't do a /reload to make it appear purple again.
-
Member
first of all, i can't thank you enough for your willingness to test this so thoroughly, your help has been absolutely irreplaceable!
the latest screenshots and your observation about the /reload fix are the "smoking gun." it confirms exactly what i suspected: the data arrives differently depending on the server core (Warmane's custom core vs. AzerothCore or TrinityCore). basically, the data is there, but the timing of when the addon "asks" the game for it is off, which is why a reload suddenly makes it work.
without your help, i would still be stuck in a endless loop of "fix, upload, fail, repeat."
my next steps:
i'm going to set up test characters on Blackrock and a few other servers to see exactly how the data packets arrive on different cores.
i need to find a universal solution so the addon works everywhere out-of-the-box, regardless of the server's backend.
this will take a bit of refactoring and time, as i want to make sure the next version is rock-solid.
i’m currently working on making the BG scanner as universal as possible (with that auto-detection we talked about), but the pet logic needs some more deep-diving to get it 100% right.
thanks again for your extremely valuable help! i'll get to work and try to find a solution as quickly as possible. i'll keep you posted!
-
Member
Yeah, I think it's best you test it for yourself. You can just create two accounts, and then duel yourself in the duel zone on Blackrock to test.
-
The Insane
For me, no more stutters with 1st version, but in case I will save ur older versions if something broke for me. :)
-
Member
Any progress, or did you give up?
Posting Permissions
- You may not post new threads
- You may not post replies
- You may not post attachments
- You may not edit your posts
-
Forum Rules
Quote