Difference between "Attack" "Ability" "Spell"

[Thornbyy]

All I want to know is that if the DK talent "Desolation" affects everything including spell damage (death coil) dots (blood plague frost fever) and the pet damage (ghoul and gargoyle) .

Talent description says it increases the damage of "All attacks" . so does this All attacks include pets spells and dots or not

[skullatbash]

you can check here: https://wowgaming.altervista.org/aowow/?spell=66803

As you can read there, you gain a buff which increases the damage you do with [Physical, Holy, Fire, Nature, Frost, Shadow, Arcane] attacks/spells by 5%
So it includes death coil, blood plague, frost fever ... etc. Everything done by you

It does NOT affect Ghoul/gargoyle